Skip to content

make check for running failing command asynchronously more robust w.r.t. obtaining full output#3881

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:fix_test_run_cmd_async
Oct 28, 2021
Merged

make check for running failing command asynchronously more robust w.r.t. obtaining full output#3881
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:fix_test_run_cmd_async

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 28, 2021

test_run_cmd_async fails occasionally because command output is consumed before command is fully completed:

 FAIL: test_run_cmd_async (test.framework.run.RunTest)
Test asynchronously running of a shell command via run_cmd + complete_cmd.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/runner/5948e8b85c06402503a29543e1b0c4ace6c14528/lib/python3.9/site-packages/easybuild/base/testing.py", line 94, in assertEqual
    super(TestCase, self).assertEqual(a, b)
  File "/opt/hostedtoolcache/Python/3.9.7/x64/lib/python3.9/unittest/case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)
AssertionError: {'done': True, 'exit_code': 123, 'output': ''} != {'done': True, 'exit_code': 123, 'output': 'FAIL!\n'}
- {'done': True, 'exit_code': 123, 'output': ''}
+ {'done': True, 'exit_code': 123, 'output': 'FAIL!\n'}
?                                             +++++++

@boegel boegel added the bug fix label Oct 28, 2021
@boegel boegel added this to the 4.5.0 (next release) milestone Oct 28, 2021
@ocaisa ocaisa merged commit 214f8e1 into easybuilders:develop Oct 28, 2021
@boegel boegel deleted the fix_test_run_cmd_async branch October 28, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants