Skip to content

fix easyconfig + extensions progress bars when --skip is used#3882

Merged
branfosj merged 3 commits intoeasybuilders:developfrom
boegel:fix_progress_bar_skipped
Oct 28, 2021
Merged

fix easyconfig + extensions progress bars when --skip is used#3882
branfosj merged 3 commits intoeasybuilders:developfrom
boegel:fix_progress_bar_skipped

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 28, 2021

Two problems being fixed here:

  • Already installed extensions that were filtered out were still being counted to determine the total size of the extensions progress bar
    • => fixed in 8d1d8c6 by updating the total count after skipping already installed extensions
  • Determining the total step count by checking which steps were being skipped didn't actually work, because the self.skip_step method actually only works after the check_readiness_step method has been run
    • => fixed in fe9b9b1 by not trying to exclude skipped steps when determining the size of the easyconfigs progress bar, but always updating it after a step was run or skipped

boegel added 2 commits October 28, 2021 18:56
@boegel
correct total count for extensions progress bar after skipping alread…
8d1d8c6 
…y installed extensions
@boegel
don't try to exclude skipped steps from total step count (just always…
fe9b9b1 
… update easyconfig progress bar), self.skip_step only really works after check_readiness_step has been run...
@boegel boegel added the bug fix label Oct 28, 2021
@boegel boegel added this to the 4.5.0 (next release) milestone Oct 28, 2021
branfosj
branfosj reviewed Oct 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly minor change as skippable is no longer user.

And the tests are hitting that download issue we've been seeing today :(

Comment thread easybuild/framework/easyblock.py Outdated
@boegel boegel force-pushed the fix_progress_bar_skipped branch from 0fecbbf to fe9b9b1 Compare October 28, 2021 17:59
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 28, 2021

And the tests are hitting that download issue we've been seeing today :(

Fix for that annoying test in #3883, hopefully relying on sources.easybuild.io will prove to be more stable than https://ftp.gnu.org...

@branfosj branfosj self-requested a review October 28, 2021 18:09
@branfosj branfosj enabled auto-merge October 28, 2021 18:09
@branfosj branfosj merged commit 6d5894e into easybuilders:develop Oct 28, 2021
@boegel boegel deleted the fix_progress_bar_skipped branch October 28, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @branfosj