add a 'sync pr' message when the PR has a mergeable state but is showing a failed status for the test suite on the last commit#3967
Merged
boegel merged 3 commits intoeasybuilders:developfrom Mar 2, 2022
Conversation
…g a failed status for the test suite on the last commit
Member
Author
|
The alternative to this is to treat |
boegel
requested changes
Mar 1, 2022
| res = not_eligible(msg_tmpl % reason) | ||
|
|
||
| if failed_status_last_commit and mergeable: | ||
| print_msg("\nThis PR is mergeable but the test suite has a failed status. Try syncing the PR.", prefix=False) |
Member
There was a problem hiding this comment.
Maybe Try syncing the PR should be a bit more specific, it could say "Try syncing the PR with the develop branch using 'eb --sync-pr-with-develop XXX'"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3490
If an easyconfigs PR fails the test suite, because a dep is in another PR or it needs a new / updated easyblock, then closing/reopening the PR to retrigger the test suite does not clear the
status_last_commiteven though themergeable_stateis fine (and the web UI will show the merge button). In this case we should give a suggestion to sync the PR.