Skip to content

add nvpsmpi toolchain definition (NVHPC + ParaStationMPI)#3970

Merged
boegel merged 3 commits intoeasybuilders:developfrom
robert-mijakovic:20220222121720_new_pr_dkfpnHXMLD
Apr 27, 2022
Merged

add nvpsmpi toolchain definition (NVHPC + ParaStationMPI)#3970
boegel merged 3 commits intoeasybuilders:developfrom
robert-mijakovic:20220222121720_new_pr_dkfpnHXMLD

Conversation

@robert-mijakovic
Copy link
Copy Markdown

(created using eb --new-pr)

@boegel boegel changed the title Adds nvpsmpi toolchain. The idea is to replicate what gompi/foss/GCC(core) do. add nvpsmpi toolchain definition ( The idea is to replicate what gompi/foss/GCC(core) do. Mar 1, 2022
@boegel boegel changed the title add nvpsmpi toolchain definition ( The idea is to replicate what gompi/foss/GCC(core) do. add nvpsmpi toolchain definition (NVHPC + ParaStationMPI) Mar 1, 2022
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.5.4?) milestone Mar 1, 2022
Comment thread easybuild/toolchains/nvpsmpi.py Outdated
EasyBuild support for npsmpi compiler toolchain (includes NVHPC and ParaStationMPI).

:author: Damian Alvarez (Forschungszentrum Juelich)
:author: Sebastian Achilles (Forschungszentrum Juelich)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robert-mijakovic This should be changed to mention yourself?

Comment thread easybuild/toolchains/nvpsmpi.py Outdated
# along with EasyBuild. If not, see <http://www.gnu.org/licenses/>.
##
"""
EasyBuild support for npsmpi compiler toolchain (includes NVHPC and ParaStationMPI).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npsmpi should be nvpsmpi?

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Apr 12, 2022

@robert-mijakovic This looks good to merge, just need to address the comments

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit ccc1a4d into easybuilders:develop Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants