Skip to content

add support for post-install patches#3974

Merged
lexming merged 2 commits intoeasybuilders:developfrom
boegel:post_install_patches
Mar 2, 2022
Merged

add support for post-install patches#3974
lexming merged 2 commits intoeasybuilders:developfrom
boegel:post_install_patches

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 1, 2022

Example use case here is a patch that we needed to apply for FLUENT, which can only be done after the installation was performed (because the files to patch don't exist in the unpacked sources, they're hidden deeper down in zipped files, etc.)

@boegel boegel added this to the 4.x milestone Mar 1, 2022
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, I just have a question and minor suggestion

Comment thread easybuild/framework/easyblock.py
Comment thread easybuild/framework/easyblock.py Outdated
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming modified the milestones: 4.x, next release (4.5.4?) Mar 2, 2022
@lexming lexming merged commit ed04e07 into easybuilders:develop Mar 2, 2022
@boegel boegel deleted the post_install_patches branch March 3, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants