Skip to content

make sure that ARCH constant has 'aarch64' (rather than 'arm64') as value on macOS ARM#4018

Merged
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:macos_ARCH_aarch64
Jun 16, 2022
Merged

make sure that ARCH constant has 'aarch64' (rather than 'arm64') as value on macOS ARM#4018
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:macos_ARCH_aarch64

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 5, 2022

Fix for problems that occur when parsing an easyconfig that relies on the ARCH constant:

$ eb Pandoc-2.13.eb -D
== Temporary log file in case of crash /tmp/eb-vbgmw5al/easybuild-shentmri.log
ERROR: Failed to process easyconfig /home/example/easybuild-easyconfigs/easybuild/easyconfigs/p/Pandoc/Pandoc-2.13.eb: Parsing easyconfig file failed: 'arm64' (line 13)

@boegel boegel added the bug fix label Jun 5, 2022
@boegel boegel added this to the release after 4.5.5 milestone Jun 5, 2022
migueldiascosta
migueldiascosta reviewed Jun 9, 2022
View reviewed changes
Comment thread test/framework/easyconfig.py Outdated
migueldiascosta
migueldiascosta reviewed Jun 9, 2022
View reviewed changes
Comment thread test/framework/easyconfig.py Outdated
@boegel boegel requested a review from migueldiascosta June 15, 2022 08:50
migueldiascosta
migueldiascosta approved these changes Jun 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jun 16, 2022

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit bae34e5 into easybuilders:develop Jun 16, 2022
@boegel boegel deleted the macos_ARCH_aarch64 branch June 16, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @migueldiascosta