Skip to content

fix code style issues reported by recent flake8 linter#4049

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:linter
Aug 3, 2022
Merged

fix code style issues reported by recent flake8 linter#4049
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:linter

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Recent flake8 complains about a missing space after keywords:

  • C-style while(condition) instead of while condition:
  • not(condition) (actually better: return self.version is not None and self.operator is not None, but that's personal preference)
  • Rewrote the if-condition checking for stream attr to remove the or
  • Missing error class in raise. Settled on ValueError as the hdlr has a missing or invalid stream value

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Fix linting issues fix code style issues reported by recent flake8 linter Aug 3, 2022
@boegel boegel merged commit c10f1e0 into easybuilders:develop Aug 3, 2022
@Flamefire Flamefire deleted the linter branch August 3, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants