first look for patch in alt_location when it is specified#4093
Merged
boegel merged 5 commits intoeasybuilders:developfrom Oct 17, 2022
Merged
Conversation
When alt_location is specified we should not look in the directory of the easyconfig for patches before alt_location.
Member
|
This extends the impact of We should add some logging though, to make it clear that the directory where the easyconfig file is being excluded because |
Contributor
Author
|
@boegel something like that then? |
…in which easyconfig file is located is being consider to locate file
…file is located is ignored when alt_location is used
boegel
requested changes
Oct 17, 2022
Member
boegel
left a comment
There was a problem hiding this comment.
And we should cover this in the test for obtain_file too.
See akesandgren#20
…t_location always log a message in obtain_file to indicate whether or directory in which easyconfig file is located is being consider to locate file + enhance test_obtain_file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When alt_location is specified we should not look in the directory of the easyconfig for patches before alt_location.