catch easyconfig parsing failure so we can generate and post a test report#4109
Merged
boegel merged 14 commits intoeasybuilders:developfrom Nov 23, 2022
Merged
Conversation
boegel
requested changes
Nov 9, 2022
Member
Author
[remove old message] Test added. |
boegel
requested changes
Nov 23, 2022
| :param ecs_with_res: processed easyconfigs with build result (success/failure) | ||
| :param init_session_state: initial session state info to include in test report | ||
| :param pr_nrs: list of ints for the PRs in the easyconfigs repository | ||
| :param gist_log: |
| :param success: boolean indicating whether all builds were successful | ||
| :param msg: message to be included in test report | ||
| :param init_session_state: initial session state info to include in test report | ||
| :param easyconfig_parse_error: error message for easyconfig parse failure |
Member
There was a problem hiding this comment.
easyconfig_parse_error -> ec_parse_error
| self.assertTrue(os.path.exists(test_report)) | ||
| if fails: | ||
| test_result = 'FAIL' | ||
| if parse_error_regex: |
Member
There was a problem hiding this comment.
rename parse_error_regex to test_report_regex, and maybe make it a list (test_report_regexs) to allow passing in multiple patterns?
Member
Author
Member
|
@branfosj Merging of #4057 introduced a (somewhat difficult to resolve) merge conflict for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)fixes #4102
If we fail during the parsing of the easyconfigs then we never get to the test report code, so we never upload a test report. During parsing of the easyconfigs we check for OS deps. This means that we do not get test reports from @boegelbot on easybuilders/easybuild-easyconfigs#16454
The report and messages using this PR generates: