Skip to content

add explicit return when no checksums match those specified in a tuple#4112

Merged
boegel merged 3 commits intoeasybuilders:developfrom
jfgrimm:fix-ignoring-tuple-checksums
Nov 23, 2022
Merged

add explicit return when no checksums match those specified in a tuple#4112
boegel merged 3 commits intoeasybuilders:developfrom
jfgrimm:fix-ignoring-tuple-checksums

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Oct 25, 2022

closes #4111

@jfgrimm jfgrimm added this to the 4.x milestone Oct 25, 2022
@jfgrimm jfgrimm changed the title Fix ignoring tuple checksums add explicit return when no checksums match those specified in a tuple Oct 25, 2022
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfgrimm The test for verify_checksum in test/framework/filetools.py should be updated accordingly (i.e. check return value, or maybe even add a test case)

@boegel boegel modified the milestones: 4.x, next release (4.6.3?) Nov 9, 2022
@jfgrimm jfgrimm requested a review from boegel November 9, 2022 11:46
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Nov 9, 2022

@boegel I've added a test, and verified that this test would have failed without the c6d3c30, ebeddec commits

@boegel boegel merged commit 86968d0 into easybuilders:develop Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error when using --ignore-checksums on an easyconfig where checksums are specified in a tuple

2 participants