Skip to content

tweak findPythonDeps.py script to use canonical package names#4118

Merged
boegel merged 2 commits intoeasybuilders:developfrom
smoors:20221102172755_new_pr_LQigyDaYQc
Nov 9, 2022
Merged

tweak findPythonDeps.py script to use canonical package names#4118
boegel merged 2 commits intoeasybuilders:developfrom
smoors:20221102172755_new_pr_LQigyDaYQc

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Nov 2, 2022

(created using eb --new-pr)

this fixes errors like the following, where a custom capitalization for package click is used in the requirements:

RuntimeError: Found no installed package for 'Click' in [{u'dependencies': [], u'package': {u'installed_version': u'2021.10.8', u'package_name': u'certifi', u'key': u'certifi'}}, {u'dependencies': [], u'package': {u'installed_version': u'2.0.12', u'package_name': u'charset-normalizer', u'key': u'charset-normalizer'}}, {u'dependencies': [], u'package': {u'installed_version': u'8.1.3', u'package_name': u'click', u'key': u'click'}}, {u'dependencies': [{u'required_version': u'>=1.4.0', u'installed_version': u'1.16.0', u'package_name': u'six', u'key': u'six'}], u'package': {u'installed_version': u'0.4.0', u'package_name': u'docker-pycreds', u'key': u'docker-pycreds'}}, {u'dependencies': [{u'required_version': u'>=3.0.1,<6', u'installed_version': u'5.0.0', u'package_name': u'smmap', u'key': u'smmap'}], u'package': {u'installed_version': u'4.0.9', u'package_name': u'gitdb', u'key': u'gitdb'}}, {u'dependencies': [{u'required_version': u'>=4.0.1,<5', u'installed_version': u'4.0.9', u'package_name': u'gitdb', u'key': u'gitdb'}], u'package': {u'installed_version': u'3.1.27', u'package_name': u'GitPython', u'key': u'gitpython'}}, {u'dependencies': [], u'package': {u'installed_version': u'3.3', u'package_name': u'idna', u'key': u'idna'}}, {u'dependencies': [], u'package': {u'installed_version': u'0.1.2', u'package_name': u'pathtools', u'key': u'pathtools'}}, {u'dependencies': [{u'required_version': None, u'installed_version': u'1.16.0', u'package_name': u'six', u'key': u'six'}], u'package': {u'installed_version': u'2.3', u'package_name': u'promise', u'key': u'promise'}}, {u'dependencies': [], u'package': {u'installed_version': u'3.19.4', u'package_name': u'protobuf', u'key': u'protobuf'}}, {u'dependencies': [], u'package': {u'installed_version': u'5.9.0', u'package_name': u'psutil', u'key': u'psutil'}}, {u'dependencies': [], u'package': {u'installed_version': u'6.0', u'package_name': u'PyYAML', u'key': u'pyyaml'}}, {u'dependencies': [{u'required_version': u'>=2017.4.17', u'installed_version': u'2021.10.8', u'package_name': u'certifi', u'key': u'certifi'}, {u'required_version': u'~=2.0.0', u'installed_version': u'2.0.12', u'package_name': u'charset-normalizer', u'key': u'charset-normalizer'}, {u'required_version': u'>=2.5,<4', u'installed_version': u'3.3', u'package_name': u'idna', u'key': u'idna'}, {u'required_version': u'>=1.21.1,<1.27', u'installed_version': u'1.26.12', u'package_name': u'urllib3', u'key': u'urllib3'}], u'package': {u'installed_version': u'2.27.1', u'package_name': u'requests', u'key': u'requests'}}, {u'dependencies': [{u'required_version': None, u'installed_version': u'2021.10.8', u'package_name': u'certifi', u'key': u'certifi'}, {u'required_version': u'>=1.26.11', u'installed_version': u'1.26.12', u'package_name': u'urllib3', u'key': u'urllib3'}], u'package': {u'installed_version': u'1.10.1', u'package_name': u'sentry-sdk', u'key': u'sentry-sdk'}}, {u'dependencies': [], u'package': {u'installed_version': u'1.3.2', u'package_name': u'setproctitle', u'key': u'setproctitle'}}, {u'dependencies': [], u'package': {u'installed_version': u'62.1.0', u'package_name': u'setuptools', u'key': u'setuptools'}}, {u'dependencies': [], u'package': {u'installed_version': u'1.0.9', u'package_name': u'shortuuid', u'key': u'shortuuid'}}, {u'dependencies': [], u'package': {u'installed_version': u'1.16.0', u'package_name': u'six', u'key': u'six'}}, {u'dependencies': [], u'package': {u'installed_version': u'5.0.0', u'package_name': u'smmap', u'key': u'smmap'}}, {u'dependencies': [], u'package': {u'installed_version': u'1.26.12', u'package_name': u'urllib3', u'key': u'urllib3'}}, {u'dependencies': [{u'required_version': u'>=7.0,!=8.0.0', u'installed_version': u'8.1.3', u'package_name': u'Click', u'key': u'click'}, {u'required_version': u'>=0.4.0', u'installed_version': u'0.4.0', u'package_name': u'docker-pycreds', u'key': u'docker-pycreds'}, {u'required_version': u'>=1.0.0', u'installed_version': u'3.1.27', u'package_name': u'GitPython', u'key': u'gitpython'}, {u'required_version': None, u'installed_version': u'0.1.2', u'package_name': u'pathtools', u'key': u'pathtools'}, {u'required_version': u'>=2.0,<3', u'installed_version': u'2.3', u'package_name': u'promise', u'key': u'promise'}, {u'required_version': u'>=3.12.0,<5,!=4.21.0,!=4.0.*', u'installed_version': u'3.19.4', u'package_name': u'protobuf', u'key': u'protobuf'}, {u'required_version': u'>=5.0.0', u'installed_version': u'5.9.0', u'package_name': u'psutil', u'key': u'psutil'}, {u'required_version': None, u'installed_version': u'6.0', u'package_name': u'PyYAML', u'key': u'pyyaml'}, {u'required_version': u'>=2.0.0,<3', u'installed_version': u'2.27.1', u'package_name': u'requests', u'key': u'requests'}, {u'required_version': u'>=1.0.0', u'installed_version': u'1.10.1', u'package_name': u'sentry-sdk', u'key': u'sentry-sdk'}, {u'required_version': None, u'installed_version': u'1.3.2', u'package_name': u'setproctitle', u'key': u'setproctitle'}, {u'required_version': None, u'installed_version': u'62.1.0', u'package_name': u'setuptools', u'key': u'setuptools'}, {u'required_version': u'>=0.5.0', u'installed_version': u'1.0.9', u'package_name': u'shortuuid', u'key': u'shortuuid'}, {u'required_version': u'>=1.13.0', u'installed_version': u'1.16.0', u'package_name': u'six', u'key': u'six'}], u'package': {u'installed_version': u'0.13.4', u'package_name': u'wandb', u'key': u'wandb'}}]

@smoors smoors added the bug fix label Nov 2, 2022
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Nov 3, 2022

cc @Flamefire

@boegel boegel added this to the next release (4.6.3?) milestone Nov 9, 2022
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title use canonical package names for findPythonDeps.py tweak findPythonDeps.py to use canonical package names Nov 9, 2022
@boegel boegel merged commit b9343c3 into easybuilders:develop Nov 9, 2022
@boegel boegel changed the title tweak findPythonDeps.py to use canonical package names tweak findPythonDeps.py script to use canonical package names Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants