check whether nvidia-smi/rocm-smi command is available before trying to run it in get_gpu_info#4131
Merged
branfosj merged 1 commit intoeasybuilders:developfrom Dec 4, 2022
Merged
Conversation
Currently the function calls `run_cmd` which throws on error AND checks the exit code which is redundant and causes a log message `"ERROR EasyBuild crashed with an error ..."` to be logged on error which is confusing as e.g it is VERY unlikely both `nvidia-smi` and `rocm-smi` are on the system. So check for existance first and suppress output and error checking of `run_cmd`.
branfosj
approved these changes
Dec 4, 2022
Member
|
Going in, thanks @Flamefire! |
get_gpu_infoget_gpu_info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the function calls
run_cmdwhich throws on error AND checks the exit code which is redundant and causes a log message"ERROR EasyBuild crashed with an error ..."to be logged on error which is confusing as e.g it is VERY unlikely bothnvidia-smiandrocm-smiare on the system.So check for existance first and suppress output and error checking of
run_cmd.