always start with empty list for banned/requires libraries to avoid that corresponding build option is updated in-place#4137
Merged
branfosj merged 1 commit intoeasybuilders:developfrom Dec 7, 2022
Conversation
…hat corresponding build option is updated in-place
branfosj
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing multiple easyconfigs, for which the list of banned libraries is different, we need to ensure that the list used for the installation of the 1st easyconfig doesn't leak to the 2nd easyconfig.
If the
banned_linked_shared_libsbuild option value is a list value somehow (for example because of the active EasyBuild configuration, or becausebanned_linked_shared_libswas manipulated through an EasyBuild hook), then we're updating that list in-place with the.extendcalls.When the
banned_linked_shared_libsbuild option is later requested again, we get the updated list.This can be avoided by always starting from an empty list, so the reference to the
banned_linked_shared_libsbuild option list value is not being reused as a reference across multiple installations.