Skip to content

update CI workflows to run 'apt-get update' if installation of packages via 'apt-get install' failed, likely due to stale apt cache#4176

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:fix-ci
Jan 10, 2023
Merged

update CI workflows to run 'apt-get update' if installation of packages via 'apt-get install' failed, likely due to stale apt cache#4176
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:fix-ci

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jan 9, 2023 •
edited
Loading

Sometimes we need to update the APT cache before installing to avoid:

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/d/dh-autoreconf/dh-autoreconf_17_all.deb  503  Service Unavailable [IP: 52.252.75.106 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@Flamefire
Fix container CI tests
a5c4273 
Need to update the APT cache before installing to avoid:

    E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/d/dh-autoreconf/dh-autoreconf_17_all.deb  503  Service Unavailable [IP: 52.252.75.106 80]
    E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
@Flamefire
Fix other GHA failures due to stale APT cache
4c0e3c1 
Unify the handling of "sudo apt[-get] install" to install all packages
at once and retry if that failed after updating the cache.
@Flamefire Flamefire changed the title Fix container CI tests Fix GHA CI due to stale APT cache Jan 10, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 10, 2023

@Flamefire is there a reason you're reverting the switch from apt-get to apt (PR #4064)?

boegel
boegel requested changes Jan 10, 2023
View reviewed changes
Comment thread .github/workflows/bootstrap_script.yml
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jan 10, 2023

@Flamefire is there a reason you're reverting the switch from apt-get to apt (PR #4064)?

Using apt doesn't seem to be what you should be doing: It prints something like "unstable CLI, don't use in scripts" or so. At the least it is noise in the CI logs hence the switch

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 10, 2023

@Flamefire is there a reason you're reverting the switch from apt-get to apt (PR #4064)?

Using apt doesn't seem to be what you should be doing: It prints something like "unstable CLI, don't use in scripts" or so. At the least it is noise in the CI logs hence the switch

At some point we were probably running with Ubuntu 22.04 (because we were using ubuntu-latest), where apt does make sense, but not anymore since #4064 (we probably overlooked the "unstable CLI" messages when doing that)

@boegel boegel changed the title Fix GHA CI due to stale APT cache update CI workflows to run 'apt-get update' if installation of packages via 'apt-get install' failed, likely due to stale apt cache Jan 10, 2023
boegel
boegel approved these changes Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.7.1?) milestone Jan 10, 2023
@boegel boegel merged commit b965ef6 into easybuilders:develop Jan 10, 2023
@Flamefire Flamefire deleted the fix-ci branch January 10, 2023 20:07
@boegel boegel mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix tests

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @jfgrimm @boegel