Skip to content

correctly restore sys.path in tests#4186

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:sys-patch
Jan 21, 2023
Merged

correctly restore sys.path in tests#4186
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:sys-patch

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

We need to modify the list not replace it.

From #3790

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flaky test as it seems to fail to download a file. Maybe we should have that already somewhere for the tests to find:

ERROR: Build of /usr/local/easybuild/easyconfigs/b/binutils/binutils-2.37.eb failed (err: "build failed (first 300 chars): Couldn't find file binutils-2.37.tar.gz anywhere, and downloading it didn't work either... Paths attempted (in order): /usr/local/easybuild/easyconfigs/b/binutils/b/binutils/binutils-2.37.tar.gz, /usr/local/easybuild/easyconfigs/b/binutils/binutils/binutils-2.37.tar.gz, /usr/local/easybuild/easyconf")

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Correctly restore sys.path in tests correctly restore sys.path in tests Jan 21, 2023
@boegel boegel merged commit 66b8ce8 into easybuilders:develop Jan 21, 2023
@Flamefire Flamefire deleted the sys-patch branch January 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants