Skip to content

replace more usages of assertTrue/False in tests#4205

Merged
jfgrimm merged 3 commits intoeasybuilders:developfrom
Flamefire:test-asserts
Feb 22, 2023
Merged

replace more usages of assertTrue/False in tests#4205
jfgrimm merged 3 commits intoeasybuilders:developfrom
Flamefire:test-asserts

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 2, 2023

I found yet another bug in the tests in test_pypi_source_urls:

self.assertTrue(eb340_url, res)

This test will always succeed, assertIn was intended.

Hence I did another RegEx-powered Search&Replace and introduced assert(Not)Exists to replace the most common use of assertTrue/False which also fixes a few bugs in error messages.

@Flamefire Flamefire force-pushed the test-asserts branch 2 times, most recently from df6f14f to 69e06ba Compare February 2, 2023 10:01
@easybuilders easybuilders deleted a comment from boegelbot Feb 15, 2023
jfgrimm
jfgrimm requested changes Feb 21, 2023
View reviewed changes
Comment thread test/framework/easyblock.py Outdated
Comment thread test/framework/easyconfigparser.py Outdated
Comment thread test/framework/filetools.py
Comment thread test/framework/filetools.py Outdated
Comment thread test/framework/systemtools.py Outdated
@jfgrimm jfgrimm added this to the 4.x milestone Feb 21, 2023
@jfgrimm jfgrimm self-assigned this Feb 21, 2023
@boegelbot

This comment was marked as outdated.

Sign in to view
jfgrimm
jfgrimm approved these changes Feb 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 22, 2023

Going in, thanks @Flamefire!

@jfgrimm jfgrimm merged commit 12fa58b into easybuilders:develop Feb 22, 2023
@Flamefire Flamefire deleted the test-asserts branch February 22, 2023 17:13
@boegel boegel modified the milestones: 4.x, next release (4.7.1?) Feb 25, 2023
@boegel boegel changed the title Replace more usages of assertTrue/False replace more usages of assertTrue/False in tests Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

@jfgrimm jfgrimm

Labels

code cleanup tests

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @boegelbot @jfgrimm @boegel