Skip to content

add support to silence deprecation warning for easyconfigs and toolchains#4207

Merged
jfgrimm merged 5 commits intoeasybuilders:developfrom
Flamefire:silence-ec-tc-deprecation
Feb 24, 2023
Merged

add support to silence deprecation warning for easyconfigs and toolchains#4207
jfgrimm merged 5 commits intoeasybuilders:developfrom
Flamefire:silence-ec-tc-deprecation

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 2, 2023

We have the silence_deprecation_warnings option but that didn't support the warnings caused by deprecated ECs and toolchains.

Add this and enhance the error message.

While at it also make the build_option return an empty list instead of None so we can grep the code for any usage like if 'foo' in build_option('silence_deprecation_warnings'):

@boegel boegel added this to the 4.x milestone Feb 15, 2023
jfgrimm
jfgrimm reviewed Feb 21, 2023
View reviewed changes
Comment thread test/framework/easyconfig.py Outdated
jfgrimm
jfgrimm reviewed Feb 21, 2023
View reviewed changes
Comment thread easybuild/tools/options.py Outdated
@Flamefire @jfgrimm
Fix typo
dd54395 
Co-authored-by: Jasper <[email protected]>
@boegelbot

This comment was marked as outdated.

Sign in to view
@Flamefire
Fix default value
9c49376 
Use the empty list as the default both in the option-add and the reverse dict.
This way we can remove the post-processing step changing `None` to `[]`.
@Flamefire
Only print "default: " for str-list options if it is not empty.
89eb00f 
This changes `(type comma-separated list; default: )` to
`(type comma-separated list)` similar to a default of `None`.
@Flamefire Flamefire force-pushed the silence-ec-tc-deprecation branch from 6f00f57 to 89eb00f Compare February 24, 2023 15:05
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 24, 2023 •
edited
Loading

This now adds a new change:

Only print "default: " for str-list options if it is not empty.
This changes (type comma-separated list; default: ) to (type comma-separated list) similar to a default of None.

That changes the output of --help in the following places (done using diff over the output before and after):

                    Parse (additional) configfiles (type comma-separated list)
                    Enable dependency resolution, using easyconfigs in specified paths (type pathsep-separated list)
                    Additional paths to consider by robot for easyconfigs (--robot paths get priority) (type pathsep-separated list)
                    Additional locations to consider in --search (next to --robot and --robot-paths paths) (type pathsep-separated list)
                    Location(s) of extra or customized easyblocks (type comma-separated list)
                    Location(s) of extra or customized module naming schemes (type comma-separated list)
                    Location(s) of extra or customized toolchains or toolchain components (type comma-separated list)
--from-pr=PR#       Obtain easyconfigs from specified PR (type comma-separated list)
                    Include easyblocks from specified PR (type comma-separated list)
                    Accept EULA for specified software [DEPRECATED, use --accept-eula-for instead!] (type comma-separated list)
                    Accept EULA for specified software (type comma-separated list)
                    Silence specified deprecation warnings out of (python2, Lmod6, easyconfig, toolchain) (type comma-separated list)

This can be discussed (if needed) in a separate PR I just opened with only that commit: #4220

jfgrimm
jfgrimm approved these changes Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm enabled auto-merge February 24, 2023 16:23
@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.7.1?) Feb 24, 2023
@jfgrimm jfgrimm merged commit 426c9c6 into easybuilders:develop Feb 24, 2023
@Flamefire Flamefire deleted the silence-ec-tc-deprecation branch February 24, 2023 18:05
@boegel boegel changed the title Add option to silence deprecation warning of ECs and toolchains Aadd option to silence deprecation warning for easyconfigs and toolchains Feb 25, 2023
@boegel boegel changed the title Aadd option to silence deprecation warning for easyconfigs and toolchains add option to silence deprecation warning for easyconfigs and toolchains Feb 25, 2023
@boegel boegel changed the title add option to silence deprecation warning for easyconfigs and toolchains add support to silence deprecation warning for easyconfigs and toolchains Mar 1, 2023
@boegel boegel changed the title add support to silence deprecation warning for easyconfigs and toolchains add support to silence deprecation warning for deprecated easyconfigs and toolchains Mar 1, 2023
@boegel boegel changed the title add support to silence deprecation warning for deprecated easyconfigs and toolchains add support to silence deprecation warning for easyconfigs and toolchains Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

change enhancement

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @boegelbot @jfgrimm @boegel