You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Additionally, it would be nice to have an easyconfig parameter to disable the check for individual packages (e.g. git-lfs), but that can be done in a follow-up PR.
I haven't looked in detail, but I think this PR might need a test that intentionally installs something without RPATH, and checks that it passes if this RPATH skipping option is used. (I'm assuming there already is a test that checks if the RPATH sanity check fails if the RPATH is not set, RPATH support is used, and the RPATH sanity check fails. In case that's not there, it should also be added)
boegel
changed the title
make the RPATH section sanity check optional
make the RPATH section check with readelf -d in sanity check optional
May 10, 2023
@casparvl You make a good point about adding a test, but all this is doing is adding support for using check_readelf_rpath=False in an easyblock when calling out to the parent sanity_check_rpath, it doesn't actually change anything at all.
Implementing a good test for this would be quite involved, and since this is blocking easybuilders/easybuild-easyblocks#2913, I'll go ahead and merge this...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See easybuilders/easybuild-easyblocks#2913 and easybuilders/easybuild-easyconfigs#17516, this makes it easier for easyblocks like
GoPackageto skip this check. The check is still enabled by default.Additionally, it would be nice to have an easyconfig parameter to disable the check for individual packages (e.g.
git-lfs), but that can be done in a follow-up PR.