avoid error being logged when checksums.json is not found#4261
Merged
boegel merged 2 commits intoeasybuilders:developfrom Sep 9, 2023
Merged
avoid error being logged when checksums.json is not found#4261boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
boegel
requested changes
May 31, 2023
Member
boegel
left a comment
There was a problem hiding this comment.
@PetrKralCZ As discussed:
- should enhance
test_obtain_fileintest/framework/easyblock.pyto also test use ofwarning_onlyoption;- to run only that specific test, use:
python3 -O -m test.framework.easyblock obtain_file
- to run only that specific test, use:
- should enhance
test_checksum_stepto verify that log error doesn't happen anymore if there's nochecksums.jsonfile;
[None]
Contributor
… checksums.json is not found
Member
[None]
boegel
approved these changes
Sep 9, 2023
Member
boegel
left a comment
There was a problem hiding this comment.
good to go now that a test that catches the issue is in place
Flamefire
reviewed
Sep 10, 2023
| # make sure there's no error logged for not finding checksums.json, | ||
| # see also https://github.com/easybuilders/easybuild-framework/issues/4301 | ||
| regex = re.compile("ERROR .*Couldn't find file checksums.json anywhere", re.M) | ||
| regex.search(stdout) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)edit: fixes #4301