don't fail in mkdir if path gets created while processing it#4300
Merged
ocaisa merged 2 commits intoeasybuilders:developfrom Jul 24, 2023
Merged
don't fail in mkdir if path gets created while processing it#4300ocaisa merged 2 commits intoeasybuilders:developfrom
mkdir if path gets created while processing it#4300ocaisa merged 2 commits intoeasybuilders:developfrom
Conversation
This may happen if a parallel build creates e.g. the sources-directory
ocaisa
reviewed
Jul 24, 2023
Co-authored-by: ocaisa <[email protected]>
ocaisa
approved these changes
Jul 24, 2023
Member
ocaisa
left a comment
There was a problem hiding this comment.
LGTM
I don't see how we can (with reasonable effort) add a test for this, so if this fixes the issue you saw I'm happy to include it.
mkdir if path gets created while processing itmkdir if path gets created while processing it
mkdir if path gets created while processing itmkdir if path gets created while processing it
Contributor
Author
|
Ouch, I missed that |
This was referenced Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may happen if a parallel build creates e.g. the sources-directory
Reported in Slack
Note that our
mkdiris documented referring tomkdir -pwhich also doesn't fail if the directory exists.