Skip to content

enhance Toolchain.get_flag to handle lists#4319

Merged
ocaisa merged 5 commits intoeasybuilders:developfrom
branfosj:enhance_get_flag
Aug 10, 2023
Merged

enhance Toolchain.get_flag to handle lists#4319
ocaisa merged 5 commits intoeasybuilders:developfrom
branfosj:enhance_get_flag

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Aug 9, 2023

Alternative to #4318

@boegel boegel added the bug fix label Aug 9, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 9, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 9, 2023

@branfosj Are you up for implementing a test for get_flag in test/framework/toolchain.py to confirm this is working as designed now for both string and list inputs? It looks like we don't have any yet...

boegel
boegel previously requested changes Aug 9, 2023
Comment thread easybuild/tools/toolchain/toolchain.py
@boegel boegel changed the title enhance get_flag to handle lists enhance Toolchain.get_flag to handle lists Aug 9, 2023
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa dismissed boegel’s stale review August 10, 2023 13:00

Supporting tuples kicks errors in unrelated places

@ocaisa ocaisa merged commit 10c2bfb into easybuilders:develop Aug 10, 2023
@branfosj branfosj deleted the enhance_get_flag branch August 10, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants