remove crash hook (since it doesn't work)#4325
Merged
branfosj merged 1 commit intoeasybuilders:developfrom Aug 12, 2023
Merged
Conversation
branfosj
approved these changes
Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash hook was introduced in #4315 by @XavierCS-dev on my request, but I noticed that it's not actually working at all: when adding a
raise RuntimeErrorin thebzip2-1.0.6.ebeasyblock, EasyBuild crashes as expected, but the crash hook or the "Encountered an unrecoverable error"message is never printed.What's more is that I realized that if it would work, it would actually be counter-productive, since we wouldn't be getting a traceback anymore that tells use valuable information about the crash.
So, for now, let's just remove it, and take some more time to figure out how to implement it correctly...