deduplicate warnings & errors found in logs and add initial newline + tab in output#4361
Merged
boegel merged 2 commits intoeasybuilders:developfrom Nov 8, 2023
Merged
Conversation
…output It isn't useful to report duplicate errors multiple times. And e.g. configure may report a wrong option at the start and end. Hence deduplicate it. Also change the logged warning/error to include a newline & tab in front of each element which makes it nicer to read. E.g.: > build failed (first 300 chars): Found 1 error(s) in command output: > configure: WARNING: unrecognized options: --with-foo, --with-bar (took 2 mins 39 secs)
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Doesn't look like those test failures can be caused by the change. One is related to network, the other is... strange |
Member
|
@Flamefire That test failure was a fluke, I've re-triggered the failing test runs, and they passed just fine on 2nd attempt, so do ignore. |
boegel
approved these changes
Nov 8, 2023
Member
boegel
left a comment
There was a problem hiding this comment.
Pretty trivial change that actually only impacts the logged warnings or raised errors for easyblocks that use actually check_log_for_errors (which currently only includes OpenBLAS and FreeFEM), so good to go.
In practice the lifetime of this change will probably be rather limited, since in EasyBuild 5.x we're switching to a now mechanism for running shell commands, which will probably make check_log_for_errors for errors pretty useless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It isn't useful to report duplicate errors multiple times. And e.g. configure may report a wrong option at the start and end. Hence deduplicate it.
Also change the logged warning/error to include a newline & tab in front of each element which makes it nicer to read. E.g.: