Skip to content

make is_rpath_wrapper faster by only checking file contents if file is not located in subdirectory of RPATH wrapper subdirectory#4406

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:speedup_is_rpath_wrapper
Apr 3, 2024
Merged

make is_rpath_wrapper faster by only checking file contents if file is not located in subdirectory of RPATH wrapper subdirectory#4406
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:speedup_is_rpath_wrapper

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Avoid uneccessary read of the FULL binary file if it cannot be an RPATH wrapper because it is in the wrong folder.

Avoid uneccessary read of the FULL binary file if it cannot be an RPATH
wrapper because it is in the wrong folder.
@boegel boegel added this to the next release (4.9.0?) milestone Dec 20, 2023
@boegel boegel changed the title make is_rpath_wrapper faster make is_rpath_wrapper faster by only checking file contents if file is not located in subdirectory of RPATH wrapper subdirectory Dec 20, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit a491c8e into easybuilders:develop Apr 3, 2024
@Flamefire Flamefire deleted the speedup_is_rpath_wrapper branch April 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants