fix LooseVersion when running with Python 2.7#4408
Merged
boegel merged 2 commits intoeasybuilders:developfrom Dec 20, 2023
Merged
fix LooseVersion when running with Python 2.7#4408boegel merged 2 commits intoeasybuilders:developfrom
LooseVersion when running with Python 2.7#4408boegel merged 2 commits intoeasybuilders:developfrom
Conversation
Member
|
@Flamefire Thanks for the fix. Friends don't let friends use Python 2 anymore btw ;) |
Contributor
Author
I know. I had a node where |
LooseVersion when running with Python 2.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)I got a failed check:
That can be reproduced with:
python2 -c "from easybuild.tools import LooseVersion; print LooseVersion('2.2') != LooseVersion('2.2')"which before this PR returnedTrueReason:
__ne__method_cmp, Python2 would use__cmp__automatically for all ops, but Python3 doesn't anymore.!=checked for object identity, i.e. the same memory address which is practically never true__ne__from__eq__which is why this almost always worked.