clean up & speed up environment checks#4409
Merged
boegel merged 2 commits intoeasybuilders:developfrom Apr 3, 2024
Merged
Conversation
e0184b6 to
983646a
Compare
`os.environ` is a dict hence the check for existance and access can usually be combined into a single access of the key avoiding the repeated lookup. Especially for `os.getenv` which already returns `None` when the key doesn't exist. Also use `.pop(key, None)` to remove a key without checking for it's existance first to avoid C&P errors
983646a to
116e6db
Compare
Contributor
Author
|
Merged develop again to rerun test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.environis a dict hence the check for existance and access can usually be combined into a single access of the key avoiding the repeated lookup.Especially for
os.getenvwhich already returnsNonewhen the key doesn't exist.Also use
.pop(key, None)to remove a key without checking for it's existance first to avoid C&P errorsI initially noticed this (performance/code quality) issue for the
get_software_*-functions: