Skip to content

adapt version pattern for EnvironmentModules to allow using development version#4416

Merged
boegel merged 1 commit intoeasybuilders:developfrom
xdelaruelle:modules_check_version
Jan 2, 2024
Merged

adapt version pattern for EnvironmentModules to allow using development version#4416
boegel merged 1 commit intoeasybuilders:developfrom
xdelaruelle:modules_check_version

Conversation

@xdelaruelle
Copy link
Copy Markdown
Contributor

When using an Environment Modules version built from git repository, version number contains git branch name, number of commit since last released version and commit hash.

This commit adapts VERSION_REGEXP for EnvironmentModules class to allow using development or locally adapted versions of Environment Modules with EasyBuild.

Fixes #4126

When using an Environment Modules version built from git repository,
version number contains git branch name, number of commit since last
released version and commit hash.

This commit adapts VERSION_REGEXP for EnvironmentModules class to allow
using development or locally adapted versions of Environment Modules
with EasyBuild.

Fixes easybuilders#4126
@xdelaruelle xdelaruelle force-pushed the modules_check_version branch from 3639cac to 1fad79e Compare December 27, 2023 19:12
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the release after 4.9.0 milestone Jan 2, 2024
@boegel boegel merged commit faf8086 into easybuilders:develop Jan 2, 2024
@boegel boegel changed the title Adapt VERSION_REGEXP for EnvironmentModules adapt version pattern for EnvironmentModules to allow using development version Jan 2, 2024
@xdelaruelle xdelaruelle deleted the modules_check_version branch January 3, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misdectection of EnvironnementModules version when use a non-released module version

2 participants