switch to run_shell_cmd where possible in easybuild.* modules#4430
Merged
branfosj merged 2 commits intoeasybuilders:5.0.xfrom Jan 4, 2024
Merged
switch to run_shell_cmd where possible in easybuild.* modules#4430branfosj merged 2 commits intoeasybuilders:5.0.xfrom
run_shell_cmd where possible in easybuild.* modules#4430branfosj merged 2 commits intoeasybuilders:5.0.xfrom
Conversation
… easyconfig files (excl. tempoary log files)
branfosj
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only remaining usage of
run_cmdineasybuild.*are those whereasynchronous=Trueis used (which is not supported yet inrun_shell_cmd)Changes to
test_index_functionsare necessary because arun-shell-cmd-output/*/out.txtfile located inself.test_prefixwas making the test fail (which doesn't make sense)