Eliminate use of distutils.version.StrictVersion, use LooseVersion instead#4476
Merged
boegel merged 6 commits intoeasybuilders:5.0.xfrom Mar 13, 2024
Merged
Conversation
distutils was removed in Python 3.12. The only reason EasyBuild uses StrictVersion is that it orders beta/rc versions before the released version, unlike LooseVersion. E.g. 5.0.0-beta < 5.0.0 (but > for LooseVersion). So a new method `is_earlier_or_prerelease(self, other, markers)` was added to LooseVersion to handle that particular case. Addresses part of easybuilders#3963
In the end this is clearer because we also need to test against a maximum version (but it is allowed to be a prerelease of that maximum version, as per StrictVersion semantics!)
Contributor
Author
|
Note that recent Lmod (certainly >=8) doesn't seem to have had any rc versions. The only tmod applicable I can find is 4.0.0-beta. Perhaps we can safely ignore that too, in which case the alternative could be to simply use LooseVersion everywhere... |
boegel
requested changes
Mar 10, 2024
Flip order of `is_prerelease` and version check for clarity. Co-authored-by: Kenneth Hoste <[email protected]>
distutils.version.StrictVersiondistutils.version.StrictVersion, use LooseVersion instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distutils was removed in Python 3.12. The only reason EasyBuild uses StrictVersion is that it orders beta/rc versions before the released version, unlike LooseVersion. E.g. 5.0.0-beta < 5.0.0 (but > for LooseVersion).
So a new method
is_prerelease(self, other, markers)was added to LooseVersion to handle that particular case.
Addresses part of #3963