Skip to content

switch from ls to bash in tests that are expecting this to be a binary#4492

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:bash
Apr 2, 2024
Merged

switch from ls to bash in tests that are expecting this to be a binary#4492
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:bash

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Mar 31, 2024 •
edited
Loading

I'm running in a Rocky 8.9 container (that is based off the one from https://github.com/easybuilders/easybuild-containers) and I hit two test failures that are caused by ls not being as expected, which causes the two tests I am changing to fail.

In the container where I see the failure:

$ file /bin/ls
/bin/ls: a /usr/bin/coreutils --coreutils-prog-shebang=ls script, ASCII text executable

$ file /bin/bash
/bin/bash: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=e4abb3b0b8951a4f746530ae2e9b85559d5fb98f, stripped

On Ubuntu:

$ file /bin/ls
/bin/ls: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=9a7a491cbe4f1b92cb270406d6642d545b7d1259, for GNU/Linux 3.2.0, stripped

$ file /bin/bash
/bin/bash: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=070009c7b6202e25d64caf24bb49c6cede3a794c, for GNU/Linux 3.2.0, stripped

@branfosj branfosj added this to the 5.0 milestone Mar 31, 2024
@branfosj branfosj changed the title switch from to bash in tests switch from ls to bash in tests that are expecting this to be a binary Mar 31, 2024
boegel
boegel approved these changes Apr 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also works fine on macOS

$ file /bin/bash
/bin/bash: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e]
/bin/bash (for architecture x86_64):	Mach-O 64-bit executable x86_64
/bin/bash (for architecture arm64e):	Mach-O 64-bit executable arm64e

@boegel boegel merged commit 1df8073 into easybuilders:5.0.x Apr 2, 2024
@branfosj branfosj deleted the bash branch April 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix EasyBuild-5.0 EasyBuild 5.0 tests

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegel