Skip to content

improve behavior when using extension which has nosource enabled#4506

Merged
smoors merged 3 commits intoeasybuilders:developfrom
Flamefire:20240412171233_new_pr_hFykoskzEw
Apr 18, 2024
Merged

improve behavior when using extension which has nosource enabled#4506
smoors merged 3 commits intoeasybuilders:developfrom
Flamefire:20240412171233_new_pr_hFykoskzEw

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Apr 12, 2024

(created using eb --new-pr)

When an extension has nosource: True set (see https://docs.easybuild.io/writing-easyconfig-files/?h=nosource#module_extensions) then self.src is an empty list

Hence we must not try to unpack the source.

Additionally we need a reasonable start_dir and optionally ext_dir. I choose to use the start_dir from the main EC. This also required a change in and related to _set_start_dir:

  • A user defined start_dir (in extension options) is likely relative to the main EC start_dir
  • If any start_dir is set (and exists) we want to change into that directory. This might be a no-op as we already are in the start_dir of the main EC if we don't unpack sources. And if we unpack sources we already do this directory change

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the release after 4.9.1 milestone Apr 18, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Apr 18, 2024

Going in, thanks @Flamefire!

@smoors smoors merged commit 7eee9b1 into easybuilders:develop Apr 18, 2024
@Flamefire Flamefire deleted the 20240412171233_new_pr_hFykoskzEw branch April 18, 2024 10:20
@boegel boegel changed the title Improve behavior when using extension with 'nosource:True' improve behavior when using extension which has nosource enabled Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants