improve behavior when using extension which has nosource enabled#4506
Merged
smoors merged 3 commits intoeasybuilders:developfrom Apr 18, 2024
Merged
Conversation
Improve the current error that we couldn't change into that directory.
Contributor
|
Going in, thanks @Flamefire! |
nosource enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)When an extension has
nosource: Trueset (see https://docs.easybuild.io/writing-easyconfig-files/?h=nosource#module_extensions) thenself.srcis an empty listHence we must not try to unpack the source.
Additionally we need a reasonable
start_dirand optionallyext_dir. I choose to use the start_dir from the main EC. This also required a change in and related to_set_start_dir: