Skip to content

implement EasyBuild API version checks to avoid mixing major versions across the EasyBuild components#4520

Merged
boegel merged 14 commits intoeasybuilders:developfrom
branfosj:compare_versions
Jun 5, 2024
Merged

implement EasyBuild API version checks to avoid mixing major versions across the EasyBuild components#4520
boegel merged 14 commits intoeasybuilders:developfrom
branfosj:compare_versions

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Apr 27, 2024

This PR will add various version checks and is EB5 prep for the EB4 branch.

  • check that framework and blocks major versions are the same and fails if not
  • check --from-pr / --include-easyblocks-from-pr branches match in use versions

@branfosj branfosj added this to the release after 4.9.1 milestone Apr 27, 2024
@branfosj branfosj marked this pull request as draft April 27, 2024 14:24
@branfosj branfosj changed the title check easyblocks and framework major are the same versions checks to avoid mixing major versions across the EB repositories Apr 27, 2024
Comment thread easybuild/tools/version.py Outdated
Comment thread easybuild/main.py Outdated
@branfosj branfosj marked this pull request as ready for review May 6, 2024 13:27
@boegel boegel changed the title versions checks to avoid mixing major versions across the EB repositories versions checks to avoid mixing major versions across the EasyBuild components May 22, 2024
…me UNKNOWN_VERSION to UNKNOWN_EASYBLOCKS_VERSION
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread easybuild/tools/github.py Outdated
improve error message on version mismatch when using `--from-pr` + rename `UNKNOWN_VERSION` to `UNKNOWN_EASYBLOCKS_VERSION`
@boegel boegel merged commit 35c7f33 into easybuilders:develop Jun 5, 2024
@branfosj branfosj deleted the compare_versions branch June 5, 2024 13:47
@boegel boegel changed the title versions checks to avoid mixing major versions across the EasyBuild components implement EasyBuild API version checks to avoid mixing major versions across the EasyBuild components Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants