trigger pre-hook in run_shell_cmd as early as possible so dry-run + trace output is correct#4544
Merged
boegel merged 3 commits intoeasybuilders:5.0.xfrom Jun 5, 2024
Merged
Conversation
Contributor
Author
|
I think it's right but it's untested, will do so later |
Member
|
@Micket We should try and reproduce the bug in a test for |
…hook is triggered sufficiently early
run_shell_cmd hooks to run earlierrun_shell_cmd as early as possible so dry-run + trace output is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4490