don't use special flags for strict, precise, loose, veryloose toolchain options on RISC-V#4576
Merged
boegel merged 2 commits intoeasybuilders:developfrom Jul 31, 2024
Merged
Conversation
Contributor
Author
|
Test report for GMP can be found here (with a modified EB version that's using the changes from this PR): |
bartoldeman
previously requested changes
Jul 12, 2024
Contributor
bartoldeman
left a comment
There was a problem hiding this comment.
Did you check loose and veryloose as well? I'm surprised they'd work.
Contributor
Author
@bartoldeman I hadn't looked into those yet (also because it seems they're not really used?), and just applied the same kind of fix that was also done for aarch64. But you're right, they will not work either, so I can remove them as well. edit: done in 37858f1. |
boegel
approved these changes
Jul 31, 2024
strict, precise, loose, veryloose toolchain options on RISC-V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to build GMP (which has
precise: Trueintoolchainopts), the configure step failed because-mno-recipis not supported on RISC-V, similar to Arm (see #3425).@julianmorillo checked with a compiler expert, and he recommended to use
-fno-reciprocal-math. This is a generic flag and used by default, so without a sensible alternative, I've just removed the flags for these toolchain options. It will then basically ignore theprecise: Trueand use the default flags.