Use default value $XDG_CONFIG_DIRS from XDG basedir spec: /etc/xdg (instead of /etc)#4591
Merged
bartoldeman merged 3 commits intoeasybuilders:5.0.xfrom Sep 6, 2024
runiq:5.0.x-etc-xdg
Merged
Use default value $XDG_CONFIG_DIRS from XDG basedir spec: /etc/xdg (instead of /etc)#4591bartoldeman merged 3 commits intoeasybuilders:5.0.xfrom runiq:5.0.x-etc-xdg
$XDG_CONFIG_DIRS from XDG basedir spec: /etc/xdg (instead of /etc)#4591bartoldeman merged 3 commits intoeasybuilders:5.0.xfrom
runiq:5.0.x-etc-xdg
Conversation
The spec mandates `/etc/xdg` instead of `/etc` for the default value of `XDG_CONFIG_DIRS` [1]. [1] https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html#variables
XDG_CONFIG_DIRS value from XDG basedir specXDG_CONFIG_DIRS value from XDG basedir spec: /etc/xdg (instead of /etc)
XDG_CONFIG_DIRS value from XDG basedir spec: /etc/xdg (instead of /etc)$XDG_CONFIG_DIRS from XDG basedir spec: /etc/xdg (instead of /etc)
Member
|
Since we're not following the spec w.r.t. the default value if We could for example at least print a warning message when we find one or more configuration files at |
Member
|
We could print a warning if |
bartoldeman
added a commit
to bartoldeman/easybuild-framework
that referenced
this pull request
Aug 30, 2024
If you don't set XDG_CONFIG_DIRS and files are present in /etc/easybuild.d we now get WARNING: Deprecated functionality, will no longer work in EasyBuild v6.0: Using /etc/easybuild.d is deprecated. Please use /etc/xdg/easybuild.d instead or add /etc to XDG_CONFIG_DIRS; see https://docs.easybuild.io/deprecated-functionality/ for more information This addresses easybuilders#4591 (comment)
If you don't set XDG_CONFIG_DIRS and files are present in /etc/easybuild.d we now get WARNING: Deprecated functionality, will no longer work in EasyBuild v6.0: Using /etc/easybuild.d is deprecated. Please use /etc/xdg/easybuild.d instead or add /etc to XDG_CONFIG_DIRS; see https://docs.easybuild.io/deprecated-functionality/ for more information This addresses #4591 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec mandates
/etc/xdginstead of/etcfor the default value ofXDG_CONFIG_DIRS.I'm pretty sure this requires documentation changes because this is potentially a breaking change, but I'm not entirely sure where. I hope a project member can point me to where. 😶💦
Fixes #4581