Skip to content

fix test_compiler_cache in case gcc is available multiple times#4599

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fix-test_compiler_cache
Aug 13, 2024
Merged

fix test_compiler_cache in case gcc is available multiple times#4599
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fix-test_compiler_cache

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

The test searches for the real command, e.g. gcc, deletes the first one found and uses the rest.
However there could be multiple ones: /usr/bin/gcc /bin/gcc In this case the second would be wrongly used as the input. Fix by converting the output of which into an array and using the 2nd entry.

The test searches for the real command, e.g. `gcc`,
deletes the first one found and uses the rest.
However there could be multiple ones: /usr/bin/gcc /bin/gcc
In this case the second would be wrongly used as the input.
Fix by converting the output of `which` into an array and using the 2nd
entry.
@boegel boegel changed the title fix test_compiler_cache fix test_compiler_cache Aug 13, 2024
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the release after 4.9.2 milestone Aug 13, 2024
@boegel boegel merged commit 877632a into easybuilders:develop Aug 13, 2024
@Flamefire Flamefire deleted the fix-test_compiler_cache branch August 14, 2024 12:39
@boegel boegel changed the title fix test_compiler_cache fix test_compiler_cache in case gcc is available multiple times Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants