Skip to content

fix test_toy_lock_cleanup_signals#4600

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
Flamefire:fix-signal-test
Aug 13, 2024
Merged

fix test_toy_lock_cleanup_signals#4600
boegel merged 1 commit intoeasybuilders:5.0.xfrom
Flamefire:fix-signal-test

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

The 1s timeout might not be enough for the build to create the log (e.g. when ran in a debugger)
Increase the timeout and also pass required arguments to actually create the lock.

The 1s timeout might not be enough for the build to create the log (e.g.
when ran in a debugger)
Increase the timeout and also pass required arguments to actually create
the lock.
@boegel boegel changed the title fix test_toy_lock_cleanup_signals fix test_toy_lock_cleanup_signals Aug 13, 2024
@boegel boegel added this to the 5.0 milestone Aug 13, 2024
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit fd6e8b8 into easybuilders:5.0.x Aug 13, 2024
@Flamefire Flamefire deleted the fix-signal-test branch August 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants