improve error messages for empty easyconfigs#4603
Merged
boegel merged 2 commits intoeasybuilders:developfrom Aug 13, 2024
Merged
improve error messages for empty easyconfigs#4603boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
The current "No software-specific easyblock 'EB_UNKNOWN' found for UNKNOWN" is rather confusing. Don't use UNKNOWN and just error/handle it.
Provide a better error message in case the EassyConfig file doesn't contain anything but whitespace.
Member
|
I think " Thanks a lot for this enhancement @Flamefire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we get:
That isn't exactly clear. So improve in 2 steps:
Noneor error iferror_on_missing_easyblockis setPossible improvement: Pass
error_on_missing_easyblockin the EasyConfig constructor and use an empty dict asextra_optionsif noeasyblock_classwas found, i.e.self.extra_options = easyblock_class.extra_options() if easyblock_class else {}This will error later in the parser which doesn't find the required keys like "name".
Not sure if that error ("missing required keys: name, ...") is cleaner than "No easyblock found as neither name nor easyblock were specified" though.