move verifying of checksums from source to fetch step, to include it with --fetch#4624
move verifying of checksums from source to fetch step, to include it with --fetch#4624boegel merged 2 commits intoeasybuilders:5.0.xfrom
source to fetch step, to include it with --fetch#4624Conversation
After `--fetch` finishes it is reasonable to expect that the build won't fail due to missing or wrong sources. However putting the checksum-step into the source-step skips over the verification and one would need to use `--stop=source` which does a lot more than necessary, e.g. creating build dirs and environment variables. Move the checksums step into the fetch step and add a test for that.
--fetchsource to fetch step, to include it with --fetch
@Flamefire Not sure if we should, |
Well now we have this (
"source" is a bit ambiguous/too general: It could be related to anything: fetching, verifying, extracting, ... and other steps are named after their called methods too. The change is for a separate PR but IMO we can discuss/decide this here already where it becomes an "issue" due to the new logic. |
We use source because that step was about verifying checksums of sources (+ patches) + unpacking the sources. If we want come up with a way of deprecating the use of |
After
--fetchfinishes it is reasonable to expect that the build won't fail due to missing or wrong sources.However putting the checksum-step into the source-step skips over the verification and one would need to use
--stop=sourcewhich does a lot more than necessary, e.g. creating build dirs and environment variables.Move the checksum step into the fetch step and add a test for that.
TODO: We should rename
SOURCE_STEPtoEXTRACT_STEP, do that here too?