Skip to content

also define functions in interactive shell session created by cmd.sh script that is produced by run_shell_cmd#4662

Merged
boegel merged 3 commits intoeasybuilders:5.0.xfrom
Micket:declare
Oct 1, 2024
Merged

also define functions in interactive shell session created by cmd.sh script that is produced by run_shell_cmd#4662
boegel merged 3 commits intoeasybuilders:5.0.xfrom
Micket:declare

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Sep 29, 2024

Adds bash functions to generated environment file.

edit: fixes #4616

@Micket Micket added this to the 5.0 milestone Sep 29, 2024
@Micket Micket force-pushed the declare branch 2 times, most recently from b6dfd78 to 5f00412 Compare September 30, 2024 15:11
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Sep 30, 2024

I did some tests and this works fine for me.

@boegel boegel changed the title Add bash functions to env.sh also defined functions in interactive shell session created by cmd.sh script that is produced by run_shell_cmd Oct 1, 2024
enhance test for `cmd.sh` script produced by run_shell_cmd to verify that `module` function is available
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel enabled auto-merge October 1, 2024 17:20
@boegel boegel changed the title also defined functions in interactive shell session created by cmd.sh script that is produced by run_shell_cmd also define functions in interactive shell session created by cmd.sh script that is produced by run_shell_cmd Oct 1, 2024
@boegel boegel merged commit dc3826d into easybuilders:5.0.x Oct 1, 2024
@boegel boegel added bug fix and removed enhancement labels Oct 1, 2024
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants