Add flushing and possible closing of stdin on run_shell_cmd#4664
Merged
boegel merged 2 commits intoeasybuilders:5.0.xfrom Oct 2, 2024
Merged
Add flushing and possible closing of stdin on run_shell_cmd#4664boegel merged 2 commits intoeasybuilders:5.0.xfrom
stdin on run_shell_cmd#4664boegel merged 2 commits intoeasybuilders:5.0.xfrom
Conversation
Contributor
|
Seems important and straight forward enough to fix for 5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
streaming_outputand writing directly from the STDIN process pipe, commands that attempt to read from STDIN until EOF, or attempt to read a larger size than what is being passed will block.An example of a bash command that will result in a blocking behavior
when executed via
Flushing and closing (in case of a non-interactive run) the STDIN as proposed in the changes would allow the example code to run
A test case has been added to catch such behavior