include path to cmd.sh script in output generated by run_shell_cmd when a command fails + use colors: red for ERROR line, yellow for path to output files + cmd.sh script#4666
Merged
branfosj merged 9 commits intoeasybuilders:5.0.xfrom Oct 15, 2024
Conversation
…en a command fails + use colors: red for ERROR line, yellow for path to output files + cmd.sh script
…d output produced by run_shell_cmd for failing command
boegel
commented
Oct 9, 2024
lexming
reviewed
Oct 9, 2024
Contributor
There was a problem hiding this comment.
LGTM but I'm not seeing any colors although I have rich installed. I see the color progress bar during installation, but then I got the following output on error:
[bold red]ERROR: Shell command failed![/bold red]
full command -> potato && ./configure --prefix=/home/lexming/easybuild/install/software/cURL/8.0.1-GCCcore-12.3.0 --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --with-zlib --with-ssl=$EBROOTOPENSSL
exit code -> 127
called from -> 'configure_step' function in /home/lexming/src/easybuild-easyblocks/easybuild/easyblocks/generic/configuremake.py (line 326)
working directory -> /home/lexming/.local/easybuild/build/cURL/8.0.1/GCCcore-12.3.0/curl-8.0.1
[bold yellow] output (stdout + stderr) -> /tmp/eb-5zxm3a9y/run-shell-cmd-output/potato-t2b3f6fz/out.txt[/bold yellow]
[bold yellow] interactive shell script -> /tmp/eb-5zxm3a9y/run-shell-cmd-output/potato-t2b3f6fz/cmd.sh[/bold yellow]
branfosj
reviewed
Oct 9, 2024
e0e9dfe to
4998e4a
Compare
4998e4a to
afd3527
Compare
branfosj
reviewed
Oct 14, 2024
branfosj
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(WIP because tests will need some love)