add --keep-debug-symbols configuration option to set default value of 'debug' toolchain option, and enable it by default so -g is included in $CXXFLAGS & co#4688
Merged
boegel merged 10 commits intoeasybuilders:5.0.xfrom Dec 11, 2024
Conversation
…iler object. This needs to be deferred due to how easybuild will need to be able to import the class before build_option is ready. The command line option has been changed to a flag, as optparse can't deal with bool types.
Contributor
Author
|
OK the optparser thing won't permit setting bools in any way. Listing options they get converted to strings, which is ugly to work with, and optparse doesn't support Also, due to how classes are sneakily initialized by EB, the static class variables aren't always defined, so, they might be |
boegel
requested changes
Nov 6, 2024
boegel
requested changes
Nov 28, 2024
-g is included in $CXXFLAGS & co
-g is included in $CXXFLAGS & co--keep-debug-symbols configuration option to set default value of 'debug' toolchain option, and enable it by default so -g is included in $CXXFLAGS & co
boegel
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also defaults to "true" as was discussed for 5.0.x.
Those concerned with disk space can consider switching this back to false.
Disclaimer: It's getting late and I'm really not sure if i can get away with inserting the default value of "debug" in the compiler option map like that. Not sure if build_option is guaranteed to be initialized when that static dict is defined.