Refactor make_extension_string method in EasyBlock class#4690
Merged
wpoely86 merged 2 commits intoeasybuilders:5.0.xfrom Dec 5, 2024
Merged
Refactor make_extension_string method in EasyBlock class#4690wpoely86 merged 2 commits intoeasybuilders:5.0.xfrom
make_extension_string method in EasyBlock class#4690wpoely86 merged 2 commits intoeasybuilders:5.0.xfrom
Conversation
The current usage was confusing as it isn't clear what should be overridden and what should be used. See easybuilders#4340 - Make `make_extension_string` a free function to just provide a common format - Promote `make_extension_list` to a public method and document it - Error when overriding the old methods - Update the module generator and remove the confusingly named member methods
b086694 to
bebf90a
Compare
bebf90a to
00b99bd
Compare
Member
wpoely86
reviewed
Dec 4, 2024
wpoely86
approved these changes
Dec 5, 2024
This was referenced Dec 5, 2024
make_extension_stringmake_extension_string method in EasyBlock class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current usage was confusing as it isn't clear what should be overridden and what should be used.
See #4340
make_extension_stringa free function to just provide a common formatmake_extension_listto a public method and document it