avoid checking loaded module twice in findUpdatedEcs.sh#4710
Merged
Micket merged 1 commit intoeasybuilders:developfrom Nov 22, 2024
Merged
avoid checking loaded module twice in findUpdatedEcs.sh#4710Micket merged 1 commit intoeasybuilders:developfrom
Micket merged 1 commit intoeasybuilders:developfrom
Conversation
The environment variables for the GCC and GCCcore ($EBROOT*) both point to the GCCcore directory which leads to checking that twice. This is true for all ECs using `altroot`. To avoid outputting the same change multiple times make the folders to check unique first. Also error if `--short` and `--diff` are both given at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The environment variables for the GCC and GCCcore ($EBROOT*) both point to the GCCcore directory which leads to checking that twice. This is true for all ECs using
altroot.To avoid outputting the same change multiple times make the folders to check unique first.
Also error if
--shortand--diffare both given at the same time.