enable keeping of symbolic links by default when copying (set keepsymlinks easyconfig parameter to True)#4773
Conversation
Not keeping symlinks caused surprising behaviour with for example installing Julia using the Tarball easyblock: it gives copies instead of symbolic links for each shared library, when they are symbolic links inside the tarball. This reverses the default behaviour to be less surprising.
|
Added a simple test. There was nothing in easyblocks to change, a few custom easyblocks explicitly set |
keepsymlinks by default
boegel
left a comment
There was a problem hiding this comment.
lgtm
This makes sense to me.
It's a bit difficult to figure out why we have this disabled by default, this was introduced before we started using Git (in March 2012...).
We should at least test some easyblocks that take into account keepsymlinks to see if there's any unexpected fallout, but I would be surprised if there is.
|
Tested Blender (PackedBinary EasyBlock), which has copies instead of symbolic links in our installed modules: Test resultBuild succeeded for 1 out of 1 Overview of tested easyconfigs (in order)
|
|
Test resultBuild succeeded for 1 out of 1 Overview of tested easyconfigs (in order)
|
Test resultBuild succeeded for 1 out of 1 Overview of tested easyconfigs (in order)
https://gist.github.com/bartoldeman/c28c907599ffe11c4575e14e6d375b39 Using before after With these 3 I have all easyblocks that directly use keepsymlinks covered (Tarball, MakeCp, and Binary via PackedBinary) |
keepsymlinks by defaultkeepsymlinks easyconfig parameter to True)
Not keeping symlinks caused surprising behaviour with for example installing Julia using the Tarball easyblock: it gives copies instead of symbolic links for each shared library, when they are symbolic links inside the tarball. This reverses the default behaviour to be less surprising.