Allow empty string in modextrapaths#4799
Merged
lexming merged 2 commits intoeasybuilders:5.0.xfrom Mar 7, 2025
Merged
Conversation
lexming
requested changes
Mar 7, 2025
Contributor
lexming
left a comment
There was a problem hiding this comment.
Thanks for reporting this issue. The case with an empty string is indeed not handled properly. See my suggested solution below
lexming
approved these changes
Mar 7, 2025
Member
|
I've enhanced the tests to cover this use case in: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR #4774, when empty string is used in
modextrapaths, for examplemodextrapaths = {'PATH': ''}indotNET-Core-8.0.302.eb, easybuild does not addpathskey intoenv_var_optsand fails silently. This induces error when checkingpathskey existence. This PR tries to make surepathsis added when empty string is used.