Make specifying exts_defaultclass optional #4800
Merged
boegel merged 4 commits intoeasybuilders:developfrom Dec 3, 2025
Merged
Make specifying exts_defaultclass optional #4800boegel merged 4 commits intoeasybuilders:developfrom
exts_defaultclass optional #4800boegel merged 4 commits intoeasybuilders:developfrom
Conversation
a106f61 to
c7ec26d
Compare
Member
|
@Flamefire I'll pick up on this again after the release of EasyBuild v5.1.0, since this change is way more involved than the last-minute regression bug fix being done in #4888 ... |
f4f4579 to
fc9cd40
Compare
Contributor
Author
|
Ok, I rebased this after #4686 caused this to conflict. Although I think the change is not so complex: We only use the property in 2 places in a single file which are both modified here. So to me the change is very local. Or is 5.1.0 so immanent there is no time for that? |
fc9cd40 to
90b3789
Compare
Contributor
Author
|
@boegel Ran into this again, can we merge this? |
- Some places could use `dict.items`. - Pylint supressions added - Ignore G002 (Logging statements should not use % formatting for their first argument) - Early return for skipped tests to avoid indent
It is NOT required when all extensions have either custom easyblocks or an `easyblock` key in their option dict. In those cases `exts_defaultclass` is redundant making it harder to write the EasyConfig. Check for a missing easyblock when actually using it so the error will be just a bit later but still (almost) the same.
0887a18 to
9c39abe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is NOT required when all extensions have either custom easyblocks or an
easyblockkey in their option dict.In those cases
exts_defaultclassis redundant making it harder to write the EasyConfig.Check for a missing easyblock when actually using it so the error will be just a bit later but still (almost) the same.
One noteworthy semi-related change is the try-finally to the
clean_up_fake_modulecall. We did that only when the exts_defaultclass was missing but not when anything else fails which looks like an omission. To keep at least the behavior for this the try-finally is required as the exception comes frominit_ext_instancesnow. As a (IMO good) side effect it will also be called for any other error happening along the way, e.g. the similar error that the default easyblock is not foundAlso some small drive-by fixes without any functional change to reduce the amount of linter warnings in the touched files.
Recent example usage for a CMakePythonPackage Easyconfig:
But also applies if only software-specific easyblocks are used and we really don't want a default