Improve test failure output for assertEqual#4807
Merged
boegel merged 5 commits intoeasybuilders:5.0.xfrom Mar 16, 2025
Merged
Conversation
`range(start, stop)` does NOT include `stop` so `len() - 1` misses the last element
`"%s" % e` yields f"AssertionError({str(e)})" so just use "%s" % str(e)
Doesn't provide additonal information and makes the output more confusing.
Currently the re-raising shows the original assertion failure inside unittest code and then "During handling of the above exception, another exception occurred:" and our assertion error. Supress the former
Avoids performance penalty on every test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the readability when a test fails:
DIFF:message had an off-by-one error that missed the last line of the diff"AssertionError"by the formatting of the original message which is just noise.a != b, so don't do our custom handling there