Skip to content

Fix missed message in trivial equal-asserts#4831

Merged
ocaisa merged 3 commits intoeasybuilders:developfrom
Flamefire:fix-assert
Apr 2, 2025
Merged

Fix missed message in trivial equal-asserts#4831
ocaisa merged 3 commits intoeasybuilders:developfrom
Flamefire:fix-assert

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

The default error is raised for trivial types but the message was not passed along and is missing in that case.

Comment thread easybuild/base/testing.py Outdated
Co-authored-by: ocaisa <[email protected]>
ocaisa
ocaisa previously approved these changes Apr 1, 2025
@Flamefire
Copy link
Copy Markdown
Contributor Author

Looks like there was an update to flake8 or previously missed check. Fixed

Comment thread easybuild/framework/easyconfig/format/version.py
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit bdc066d into easybuilders:develop Apr 2, 2025
37 checks passed
@Flamefire Flamefire deleted the fix-assert branch April 2, 2025 08:26
@boegel boegel added the bug fix label Apr 2, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 2, 2025
@boegel boegel added the tests label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants